-
Notifications
You must be signed in to change notification settings - Fork 108
[WIP] fix local streaming bug #379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: ce4263e The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
075bf43 to
b4c42f7
Compare
|
You must have Developer access to commit code to Vercel Labs on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes. Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles |
|
Deployment failed with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
| } | ||
| if (chunk.chunk.byteLength) { | ||
| controller.enqueue(chunk.chunk); | ||
| process.stdout.write('.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| process.stdout.write('.'); |
Debug output code (process.stdout.write('.')) was accidentally left in the production fix and should be removed.
View Details
Analysis
Debug output code accidentally left in stream reader
What fails: The readFromStream() function in packages/world-local/src/streamer.ts (line 185) writes a debug dot character to stdout every time a chunk is enqueued during stream reading, polluting stdout with unwanted output.
How to reproduce: Create a stream with multiple chunks and read from it:
const streamer = createStreamer('./test-data');
const chunks = ['chunk1', 'chunk2', 'chunk3'];
for (const chunk of chunks) {
await streamer.writeToStream('test-stream', Promise.resolve('run-1'), chunk);
}
await streamer.closeStream('test-stream', Promise.resolve('run-1'));
const stream = await streamer.readFromStream('test-stream');
const reader = stream.getReader();
while (true) {
const { done } = await reader.read();
if (done) break;
// Observe: three dots printed to stdout (one per chunk)
}Result: Three dots appear on stdout, one for each chunk enqueued
Expected: No debug output should appear on stdout. The function should silently enqueue chunks without printing to console.
Root cause: Commit d6b97db ("another fix") inadvertently added process.stdout.write('.'); at line 185, which should have been removed before commit. This was not mentioned in the commit message and is not part of the intended fix ("Create a copy of the data when resolving a stream to prevent detachment").
d6b97db to
54fcf1b
Compare
54fcf1b to
3b65788
Compare
. another fix . .
510b85f to
ce4263e
Compare
| { | ||
| "name": "@workflow/world-local", | ||
| "version": "5.0.0-beta.10", | ||
| "version": "4.0.0-beta.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "version": "4.0.0-beta.10", | |
| "version": "5.0.0-beta.11", |
The package version was downgraded from 5.0.0-beta.10 to 4.0.0-beta.10, which is backwards and will cause version conflicts.
View Details
Analysis
Version downgrade in @workflow/world-local package
What fails: The version in packages/world-local/package.json was incorrectly downgraded from 5.0.0-beta.10 to 4.0.0-beta.10, violating semantic versioning and causing version conflicts with package managers.
How to reproduce:
# Check git history
git log --oneline -5 -- packages/world-local/package.json
# Commit ce4263e has version "4.0.0-beta.10" (incorrect)
# Commit 2856d66 has version "5.0.0-beta.10" (correct - previous version)Result: Version downgraded from 5.0.0-beta.10 to 4.0.0-beta.10, which is a backward version change. The associated changeset specifies "patch" level changes but the version number went DOWN instead of UP.
Expected: Version should be 5.0.0-beta.11 (bumping the patch version from the previous beta.10), maintaining proper semver progression. Per semantic versioning, patch versions must increment monotonically within the same major and minor version.
Fixed: Version corrected to 5.0.0-beta.11 to maintain proper version ordering and consistency with the "patch" level changeset.
|
Superseded by #391 |
Seeing this issue sporadically when trying to
getReadablewith a startIndex in local world onlythis branch is to fix and test